Integrate menhir parser and elaborator tests #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrus-
added
needs-polish
Closed
…sues with the output from the menhir -> DHExp
…es & changed tests to reflect this
…ng to better handle parens + added free var application elaboration test with menhir
… added ids to the pats
…ory, added in the plus to the fix point function name
cyrus-
requested changes
Jan 7, 2025
test/Test_ExpToSegment.re
Outdated
| string, | ||
| "Match statement", | ||
| serialized, | ||
| "case x end" // TODO Why is this not serializing the cases |
There was a problem hiding this comment.
fix and mark this as a skipped test until we fix the issue (file the issue)
| * serialize it, parse it with Menhir, and compare to the original. | ||
| * | ||
| * TODO This fails due to types not being serialized on constructors | ||
| * and some other ExpToSegment inconsistencies |
There was a problem hiding this comment.
@cyrus- these are the bugs I've found with the qcheck test.
This was referenced Jan 7, 2025
7h3kk1d
commented
Jan 7, 2025
Comment on lines
+448
to
+453
| ( | ||
| settings.inline | ||
| ? [] : [Secondary(Secondary.mk_newline(Id.mk()))] | ||
| ) | ||
| @ [mk_form("rule", id, [p])] | ||
| @ (e |> fold_if(settings.fold_case_clauses)), |
There was a problem hiding this comment.
This is also solved in #1450
There was a problem hiding this comment.
Merging either PR first is fine.
cyrus-
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a Menhir-based parser for Hazel's textual syntax, designed to support the elaborator's unit testing. The textual representation is supposed to support pre and post elaboration, so special syntax is used for post-elaboration forms. Key components include: